Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vehicle not moving when being remotely controlled #78850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SurFlurer
Copy link
Contributor

@SurFlurer SurFlurer commented Dec 30, 2024

Summary

Bugfixes "Fix vehicle not moving when being remotely controlled"

Purpose of change

Fix #74689

Describe the solution

Remove 2 short-circuit logic introduced by #75467 that are not based on exactly safe assumptions. Basically I just left the only special case handling that was for testing purpose.

Describe alternatives you've considered

Testing

Remotely controlled vehicles drive fine.

Additional context

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 30, 2024
@SurFlurer SurFlurer closed this Jan 3, 2025
@SurFlurer SurFlurer reopened this Jan 3, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote controlling vehicles no longer works.
1 participant