Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Fix response schema of the "getaccountstate" RPC method #714

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

dethos
Copy link
Contributor

@dethos dethos commented Nov 9, 2018

What current issue(s) does this address, or what feature is it adding?
This pull request tries to fix #713

How did you solve this problem?
Changed the JSON serialization of the AccountState instances

How did you make sure your solution works?
Tested manually and updated the automatic test

Are there any special changes in the code that we should be aware of?
No, I do think I fixed it everywhere, but something might be missing.

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@dethos dethos changed the title Fix getaccountstate RPC method response Fix getaccountstate RPC method response schema Nov 9, 2018
@coveralls
Copy link

coveralls commented Nov 9, 2018

Coverage Status

Coverage increased (+0.003%) to 83.034% when pulling b43536c on dethos:fix-get-account-state into edf756d on CityOfZion:development.

@dethos dethos changed the title Fix getaccountstate RPC method response schema Fix response schema of the "getaccountstate" RPC method Nov 9, 2018
@ixje
Copy link
Member

ixje commented Nov 9, 2018

Thanks! 👍

@ixje ixje merged commit 8690a46 into CityOfZion:development Nov 9, 2018
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants