Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Persist reset fix #611

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Persist reset fix #611

merged 2 commits into from
Sep 18, 2018

Conversation

localhuman
Copy link
Collaborator

What current issue(s) does this address, or what feature is it adding?

  • Balance mismatches in neo/gas were being caused by the resetting of storages during failed smart contract invocations.

How did you solve this problem?

  • DBCollection now has a method MarkForReset which caches a change-set that can be reverted back to in the case of a failed smart contract invocation.

How did you make sure your solution works?

  • Manually verify balances that were previously incorrect

Are there any special changes in the code that we should be aware of?

  • Currently re-syncing mainnet Chain and Notification databases, will add another PR once those are complete.

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

coveralls commented Sep 17, 2018

Coverage Status

Coverage increased (+0.02%) to 80.25% when pulling 0cc9c03 on persist-reset-fix into cfc8361 on development.

@jseagrave21
Copy link
Contributor

@localhuman This looks great! It looks like it should address #578 but will it also fix the issues I am seeing in #605 ?

@localhuman
Copy link
Collaborator Author

Not sure about #605. I frequently use wallets with multiple addresses and have not seen that behavior.

@localhuman localhuman changed the base branch from master to development September 18, 2018 06:46
@localhuman localhuman merged commit 951de3a into development Sep 18, 2018
@ixje ixje deleted the persist-reset-fix branch October 2, 2018 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants