Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API list endpoint for OIDC scopes #74

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

tuomas777
Copy link
Contributor

The endpoint includes all the scopes: the default ones coming from Django
OIDC provider, the custom ones defined in CombinedScopeClaims class, and
also the scopes for the APIs.

Refs City-of-Helsinki/omahelsinki#136

The endpoint includes all the scopes: the default ones coming from Django
OIDC provider, the custom ones defined in CombinedScopeClaims class, and
also the scopes for the APIs.
@ghost ghost assigned tuomas777 Nov 20, 2018
@ghost ghost added the in progress label Nov 20, 2018
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #74 into master will increase coverage by 0.52%.
The diff coverage is 98.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   80.06%   80.58%   +0.52%     
==========================================
  Files         102      104       +2     
  Lines        3406     3503      +97     
==========================================
+ Hits         2727     2823      +96     
- Misses        679      680       +1
Impacted Files Coverage Δ
tunnistamo/urls.py 69.38% <100%> (+1.3%) ⬆️
scopes/tests/test_api.py 100% <100%> (ø)
scopes/api.py 98.21% <98.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30153f...8ee6e86. Read the comment docs.

@tuomas777 tuomas777 requested a review from tituomin November 20, 2018 12:46
tunnistamo/urls.py Show resolved Hide resolved
scopes/api.py Show resolved Hide resolved
Copy link
Contributor

@juyrjola juyrjola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tituomin tituomin merged commit cf2ec02 into City-of-Helsinki:master Nov 30, 2018
@ghost ghost removed the in progress label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants