Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aetest loop doc improv #173

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aitestino
Copy link

Corrected typos, sentence structure, and overall added clarity as in #172

@aitestino aitestino requested a review from a team as a code owner July 22, 2022 20:14
@aitestino aitestino requested review from ademz and domachad July 22, 2022 20:14
@mjbear
Copy link

mjbear commented Nov 5, 2024

On #172 @GerriorL indicated "testscript" and "testcase" were intended words.
I've posed a question on that PR whether it helps clarity to also capitalize those words (ex: TestScript).

@aetest.cleanup
def cleanup(self):
pass

# this testscript's resulting sections would look like this below
# This test script's resulting sections would look like this below
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear if this is referring to a code object type so it's probably safe to leave this as two words.

Where it's clear the words are referring to Python objects:
* test case > Testcase
* test script > TestScript
@mjbear
Copy link

mjbear commented Nov 5, 2024

Provided updates via aitestino#2

Update Testcase/TestScript words in loop.rst
@mjbear
Copy link

mjbear commented Nov 7, 2024

@domachad
There have been some changes made and you might want to re-review this PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants