Merge pull request #365 from TheCraigHewitt/feature/defer-register-po…

…st-types

Feature/defer register post types

php/classes/controllers/class-admin-controller.php

@@ -54,7 +54,7 @@ public function bootstrap() {
 		add_action( 'init', array( $this, 'load_localisation' ), 0 );
 
 		// Regsiter podcast post type, taxonomies and meta fields.
-		add_action( 'init', array( $this, 'register_post_type' ), 1 );
+		add_action( 'init', array( $this, 'register_post_type' ), 11 );
 
 		// Register podcast feed.
 		add_action( 'init', array( $this, 'add_feed' ), 1 );
@@ -241,7 +241,6 @@ public function register_post_type() {
 	 * @return void
 	 */
 	private function register_taxonomies() {
-
 		$podcast_post_types = ssp_post_types( true );
 
 		$series_labels = array(

php/classes/controllers/class-frontend-controller.php

@@ -2,7 +2,6 @@
 
 namespace SeriouslySimplePodcasting\Controllers;
 
-use SeriouslySimplePodcasting\Helpers\Log_Helper;
 use stdClass;
 use WP_Query;
 

php/classes/helpers/class-log-helper.php

@@ -14,6 +14,9 @@ class Log_Helper {
 	public $log_path;
 	public $log_url;
 
+	/**
+	 * Log_Helper constructor.
+	 */
 	public function __construct() {
 		$this->log_dir_path = SSP_PLUGIN_PATH . 'log' . DIRECTORY_SEPARATOR;
 		$this->log_dir_url  = SSP_PLUGIN_URL . 'log' . DIRECTORY_SEPARATOR;
@@ -22,7 +25,16 @@ public function __construct() {
 		$this->check_paths();
 	}
 
+	/**
+	 * Checks if the logging paths exist, and attempts to create them
+	 * Will only fire if SSP_DEBUG is set and true
+	 *
+	 * @return bool
+	 */
 	public function check_paths() {
+		if ( ! defined( 'SSP_DEBUG' ) || ! SSP_DEBUG ) {
+			return false;
+		}
 		if ( ! is_dir( $this->log_dir_path ) ) {
 			mkdir( $this->log_dir_path );
 		}

readme.txt

@@ -102,6 +102,10 @@ You can find complete user and developer documentation (along with the FAQs) on
 
 == Changelog ==
 
+= 1.20.2-beta =
+* 2019-05-30
+* [FIX] Fixes a legacy bug where post type registration was prioritised over other custom post types
+
 = 1.20.1 =
 * 2019-05-28
 * [FIX] Fixes a bug where subscribe links still show, even if not url has been set

seriously-simple-podcasting.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * Plugin Name: Seriously Simple Podcasting
- * Version: 1.20.1
+ * Version: 1.20.2-beta
  * Plugin URI: https://www.castos.com/seriously-simple-podcasting
  * Description: Podcasting the way it's meant to be. No mess, no fuss - just you and your content taking over the world.
  * Author: Castos
@@ -26,7 +26,7 @@
 use SeriouslySimplePodcasting\Controllers\Options_Controller;
 use SeriouslySimplePodcasting\Rest\Rest_Api_Controller;
 
-define( 'SSP_VERSION', '1.20.1' );
+define( 'SSP_VERSION', '1.20.2-beta' );
 define( 'SSP_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
 define( 'SSP_PLUGIN_PATH', plugin_dir_path( __FILE__ ) );