Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
…nd onChange props
…nd onChange props
…ttemptDateTime' for sorting
This commit updates the Submission.ts file to include the SubmissionsArraySchema, which is an array schema for the Submission object. This change allows for better validation and handling of multiple submissions.
This commit updates the useSubmissions hook in the frontend/src/hooks/useSubmissions.tsx file. It adds the SubmissionsArraySchema import from the '@/types/submission' module. This change ensures that the hook returns data in the correct format.
This commit updates the CodeEditor component to include a new prop called 'value'. This prop allows the parent component to control the value of the code editor. The 'value' prop is now passed to the Monaco Editor component and is used to set the initial value of the editor. Additionally, the 'value' prop is also passed to the onChange event handler, ensuring that any changes made in the editor are reflected in the parent component.
… userId and Integer for questionId
The code changes in question.tsx and submission.ts update the types of userId and questionId from string to number to align with the backend API. This ensures consistency and improves data integrity.
Bug fixes and enhancements
Separate kubernetes for db
Add delete user function for admin
Fix Video Not Showing
When user tries to update their own details, they cannot because isAdmin is sent. This commit updates the check in the UsersController to only reject if the user is trying to change their admin position.
User should be able to submit and see the form errors, instead of the button being disabled.
Bug fix and UI enhancement
Remove deployment workflow
Final Milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @LHeng1 @m1oojv @Jnjy @zsh-eng @tim-pipi