Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlay merge error #346

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix overlay merge error #346

merged 1 commit into from
Apr 30, 2024

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Apr 5, 2024 •
edited
Loading

This PR solves a problem when a signal is added in an overlay and the signal is "deeper" down in an instantiated tree. A hypothetical example below, adding a temperature signal for front left brake in an overlay. Current result is that Temperature signal is not included in the final result.

Vehicle.Chassis.Axle.Row1.Wheel.Left.Brake.Temperature:
  datatype: float
  type: sensor
  description: Brake Temperature FL
  dbc2vss:
    interval_ms: 1000
    signal: BrakeTempFL3FE
    transform:
      math: "floor(x-40)"

@erikbosch erikbosch marked this pull request as ready for review April 8, 2024 07:51
@erikbosch erikbosch mentioned this pull request Apr 9, 2024
Closed
@erikbosch
Copy link
Collaborator Author

MoM:

  • Please review until Thursday EOB
  • Merge Friday if no remarks

@erikbosch erikbosch mentioned this pull request Apr 11, 2024
Closed
@erikbosch
Fix overlay merge error
c8c8a2e 
Fixes COVESA/vehicle_signal_specification#736

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@erikbosch
Copy link
Collaborator Author

MoM: Merge

@erikbosch erikbosch merged commit e41ceb2 into COVESA:master Apr 30, 2024
5 checks passed
@erikbosch erikbosch mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianSchildt SebastianSchildt Awaiting requested review from SebastianSchildt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikbosch