-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsc_ast.py: Implement version_label #48
Conversation
vsc/model/vsc_ast.py
Outdated
@@ -483,6 +483,9 @@ class Namespace: | |||
minor_version: Optional[int] = None | |||
""" Provides the minor version of the namespace. """ | |||
|
|||
version_label: Optional[str] = str() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we discussed what to do with the syntax file now when we at least partially can generate documentation. Keep up-to-date for now, or let it degrade until we are ready to replace it with a generated version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we discussed what to do with the syntax file now when we at least partially can generate documentation. Keep up-to-date for now, or let it degrade until we are ready to replace it with a generated version?
The syntax file ought to be removed from the VSC repository since the IFEX documentation now provides all that information. The VSC project can optionally refer to IFEX for the definition of the language used for the service descriptions.
Sorry, I haven't participated in the discussion and maybe this question has been clarified already. Only wanted to ask why can't we use simply version: Optional[str] = str() Where |
Signed-off-by: Gunnar Andersson <gunnar_dev@nospam@novaspring.eu>
Rebased. |
Yes, a standard version string containing
I generally like the idea of reusing an existing specification but:
|
NOTE! Optional patch version still missing. see #44 |
As discussed in #44