Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unordered maps for tickets #592 #593

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

sebastianelsner
Copy link
Contributor

Hej,

as proposed in #592 please check this PR for validity.

We have tried it and it works so far.

Does it introduce any incompatibilities with the store or in the protocol?

@timurhai
Copy link
Member

Hello!
Yes, we can just rename std::map to std::unordered_map for tickets, should work.
But now there is a new protocol version in repo.
This is 3.4.0 in master now. And it is not finished. Protocol can be changed again before 3.4.0 release.

@timurhai timurhai merged commit 8279bf3 into CGRU:master Mar 11, 2024
@sebastianelsner
Copy link
Contributor Author

Fine for me with the protocol, I backport this anyways to 3.3.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants