Trust additional binaries signed by Microsoft #3554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes about:third-party not trusting some DLLs from Microsoft that are required.
|
Well this is a bit embarrassing but I didn't realize that the main/current branch was switched out with Waterfox 6.5.X and this pull request was meant to solve an issue that might only be present in Waterfox G6, I haven't tried out the 6.5 beta but a check of the installer revealed that the mentioned DLL files are no longer shipped with Waterfox and are instead grabbed/called from system32 (which is a good thing!) meaning that this pull request probably isn't needed/relevant anymore since as far as I understand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes about:third-party not trusting some DLLs from Microsoft that are required similar to #3269.
makes it so DLLs such as
vcruntime140.dll,vcruntime140_1.dll, andmsvcp140.dllstop being detected in about:third-party, The reason this happens in the first place is because it seems like only the first signature string within a DLL is checked and for these DLLs "Microsoft Windows Software Compatibility Publisher" is the first signature.