Improve BAML Parser #785
Merged
Improve BAML Parser #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support parsing fractions as numbers (LLMs tend to like this for fractions, especially repeating values). 1/3 -> 0.33
* Better parsing of objects of single keys:
If the schema is { foo: { bar: string }}
These all will parse into that:
{ bar: "..." }
{ foo: { bar: "..." }}
"..." will not auto parse into { foo: { bar: "..." }}
* support "," with trailing spaces in parser. Infer as end of key. Sometimes LLMs will use ", " token instead of "," token.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added support for parsing fractions as numbers (
engine/baml-lib/jsonish/src/deserializer/coercer/coerce_primitive.rs) - Improved handling of objects with single keys (
engine/baml-lib/jsonish/src/deserializer/coercer/ir_ref/coerce_class.rs) - Introduced
InferedObjectflag and related methods (engine/baml-lib/jsonish/src/deserializer/deserialize_flags.rs) - Enhanced handling of trailing spaces after commas (
engine/baml-lib/jsonish/src/jsonish/parser/fixing_parser/json_parse_state.rs) - Added new test cases for fractions, single keys, and trailing commas (
engine/baml-lib/jsonish/src/tests/test_basics.rs,engine/baml-lib/jsonish/src/tests/test_class.rs)
11 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| if v.conditions() | ||
| .flags() | ||
| .iter() | ||
| .any(|f| matches!(f, Flag::InferedObject(jsonish::Value::String(_)))) |
There was a problem hiding this comment.
Spelling: Typo in Flag::InferedObject. Should be Flag::InferredObject.
Suggested change
| .any(|f| matches!(f, Flag::InferedObject(jsonish::Value::String(_)))) | |
| .any(|f| matches!(f, Flag::InferredObject(jsonish::Value::String(_)))) |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated
docs/README.mdto use Fern instead of Mintlify - Added
docs/assets/styles.cssfor CSS styling updates - Introduced
docs/docs.ymlfor improved documentation structure - Modified multiple
.mdxfiles to add slugs, update code block identifiers, and improve formatting - Removed
docs/mint.jsonanddocs/v3/analytics/overview.mdxfiles
67 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the schema is { foo: { bar: string }}
These all will parse into that:
"..." will not auto parse into
{ foo: { bar: "..." }}If the schema is { foo: { bar: int }}
These all will parse into that:
"... 123 ..." will not parse into
{ foo: { bar: int }}