Literals syntax highlight #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to c2df7e2 in 20 seconds
More details
- Looked at
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_haZGLRuIASTRbbVp
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3eb48be in 13 seconds
More details
- Looked at
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. typescript/vscode-ext/packages/syntaxes/baml.tmLanguage.json:158
- Draft comment:
Thestring_literalpattern is correctly moved to a separate repository entry. Ensure that all references to string literals in the file use this new entry for consistency. - Reason this comment was not posted:
Confidence changes required:20%
The PR description indicates the addition of syntax highlighting for string literals and boolean constants. The change involves moving the string literal pattern to a separate repository entry, which is a good practice for modularity. However, the pattern for boolean constants is already present, so no changes are needed there.
Workflow ID: wflow_56ddV18WoYDfokbX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add syntax highlighting for string literals and boolean constants in
baml.tmLanguage.json.name:string.quoted.doubleinbaml.tmLanguage.json.trueandfalsewithname:constant.language.booleaninbaml.tmLanguage.json.This description was created by
for 3eb48be. It will automatically update as commits are pushed.