Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finished with ticket FP-82. #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Finished with ticket FP-82. #84

wants to merge 2 commits into from

Conversation

JoseGuevara29
Copy link
Contributor

Finished with ticket FP-82. I have made the component of the intake f…rm to the specs of the figma

Loom video below:
https://www.loom.com/share/431d339af2cc45d1bd5459564dedf059

ashtilawat23
ashtilawat23 requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@ashtilawat23 ashtilawat23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's make a more detailed title
  • Remove commented out code
  • Reestablish package-lock from main
  • Reestablish package.json as well

package.json Show resolved Hide resolved
src/components/common/ClientIntakeForm/ClientIntakeForm.js Outdated Show resolved Hide resolved
src/components/common/ClientIntakeForm/IntakeForms/Employment/EmploymentHistory.js Show resolved Hide resolved
src/components/common/ClientIntakeForm/IntakeForms/Employment/EmploymentIntake.js Outdated Show resolved Hide resolved
aurelions
aurelions suggested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@aurelions aurelions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, just would get rid of the block of commented code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashtilawat23 ashtilawat23 ashtilawat23 requested changes

@aurelions aurelions aurelions requested changes

@publiminal publiminal Awaiting requested review from publiminal

@JordonP123 JordonP123 Awaiting requested review from JordonP123

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseGuevara29 @aurelions @ashtilawat23