-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created consensus.go_util.go and edited consensuscore,rpc and types … #51
Created consensus.go_util.go and edited consensuscore,rpc and types … #51
Conversation
DarkLord017
commented
Sep 21, 2024
- I added some structs in types as in geth many fields were private and was different from alloy(from which helios was importing)
- in RPC Just edited a type for more correct usage
- In consensus_core made all public and implemented not implemented fields
- Wrote consensus/consensus.go and consensus/utils.go
- Previous PR issues have been resolved and are in this PR so please check
- Also made a single array of bytes in utils for easy transformation from structs to byte array
@star-gazer111 please review |
@DarkLord017 u were supposed to create a new utils.go in the utils folder that contains all the functions of the currently existing three different utils.go and remove the existing ones. |
I'm creating that one consensus me time lag gaya |
What does this PR exactly does and which issue does it solves can u please reference? |
Okay thanks. |
I'll check n tell u |
@star-gazer111 wait verify merkle proof vo use karke hi likh Deta |
Using index too for merkle proof validation
@star-gazer111 sir merkle tree library use karke kar liya utils me but vo function use mr nhi liya kyuki usme index ke bina hi validation ho rha |