Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: update toolchain to 1.73.0 #1144

Merged
merged 4 commits into from
Nov 3, 2023
Merged

rust: update toolchain to 1.73.0 #1144

merged 4 commits into from
Nov 3, 2023

Conversation

benma
Copy link
Collaborator

@benma benma commented Nov 2, 2023

Saves around 10kB in binary size.

benma added 4 commits November 2, 2023 11:19
Also run `cargo update`, which includes the same fix as
BitBoxSwiss#1140 (bump
rustix from 0.36.11 to 0.36.16).
from_i32 as been deprecated in favour of TryFrom.

The `?` turns the decode error into an InvalidInput error, see the
addition in `error.rs`.
Contains Rust toolchain 1.73.
Copy link
Collaborator

@asi345 asi345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the Docker image and container, it works without a problem.
tACK!

@benma benma merged commit ed6242b into BitBoxSwiss:master Nov 3, 2023
1 check passed
@benma benma deleted the update branch November 3, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants