Bip85 #1066
Merged
Bip85 #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
bip85-2
branch
8 times, most recently
from
0518f0e to
ada8c8c
Compare
|
Note: add the word confirmation step like when showing the main mnemonic. |
Done |
Closed
In BIP-85, the user needs to specify the index at which to derive a secret. This change allows the keyboard input to be used to enter integers.
benma
force-pushed
the
bip85-2
branch
3 times, most recently
from
cf7d1db to
7325573
Compare
asi345
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
The implementation conforms with what specified in https://github.com/bitcoin/bips/blob/master/bip-0085.mediawiki#bip39. tACK
See https://github.com/bitcoin/bips/blob/master/bip-0085.mediawiki#bip39. Some of the other "apps" (derived secrets) using BIP-85 are not added with this commit and may be added in the future. For now we add the app that is probably used the most, which is deriving BIP-39 mnemonics. The new protobuf messages are empty messages instead of reusing e.g. the `Success {}` message so they can be extended in the future without having to return different types of response messages (e.g. Success OR a custom message).
This moves the mnemonic word confirmation code from the api module to the workflow module, so it can be used by both the show_mnemonic API call and the bip85 API call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.