-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getAnnotation.R #29
base: master
Are you sure you want to change the base?
Conversation
I was getting errors that the FTP download was not completing. The same as this issue from 2 years ago: BgeeDB#27. I found this was because of how the Bgee database and R package is set up now, the path that is set to where files are downloaded and extracted (pathToData), is the same path that line 76 of getAnnotation.R script deletes by unlinking (dirname(myData)). This removes all downloaded BGee data when running and therefore returns an error. I guess this line was left over from a previous set up. I think just removing will be a fix with no problems.
Hi @garethgillard |
Hi @jwollbrett, thanks for looking into this. Good to find and one bug, unfortunately there is still the problem with the line of code I highlighted in this pull request. It deletes all downloaded data right after downloading it, which makes the package unusable. I'm making a little tutorial on using Bgee and would very much like to showcase using the R package. I recommend updating the package with the pull request to fix it. |
Hi @garethgillard, I did not manage to reproduce the bug described in #27 . I tried both using the master branch of our git repository and the last Bioconductor release (3.19). |
I have some more information around the problem, different versions give different results (R version = 4.4.1). The Master branch and Bioconductor 3.19 are version 2.30.1 of the BgeeDB package which link still to Bgee release 15_0. To get the 15_2 release, I can use the devel version on Bioconductor: This is version 2.31.0 of the BgeeDB package, and it's this version that's giving me errors with If I use the git develop branch however ( |
Hi @garethgillard, In general I do not recommend to use the bioconductor devel branch especially to create a tutorial. It is the branch we use to test that our new implementations pass the bioconductor build so you can have issues working with it. I am currently working on the bioconductor devel branch and did not check the build process in Bioconductor. It looks I had an error in the documentation of an example. I solved that error and the next build should solve the issue on that branch too. It can take up to 48h. |
I was getting errors that the FTP download was not completing. The same as this issue from 2 years ago: #27. I found this was because of how the Bgee database and R package is set up now, the path that is set to where files are downloaded and extracted (pathToData), is the same path that line 76 of getAnnotation.R script deletes by unlinking (dirname(myData)). This removes all downloaded BGee data when running and therefore returns an error. I guess this line was left over from a previous set up. I think just removing will be a fix with no problems.