Sandbox Process Creation

[pixeebot]

Enhance Dependency Installation Safety

• Purpose:
  Improve the safety of the dependency installation process.
• Key Changes:
  • Replaced direct call to run with safe_command.run for enhanced security.
  • Added a specific version for the security package in requirements.txt.
• Impact:
  This change mitigates potential security risks during package installation.

✨ Generated with love by Kaizen ❤️

Original Description

This codemod sandboxes all instances of [subprocess.run](https://docs.python.org/3/library/subprocess.html#subprocess.run) and [subprocess.call](https://docs.python.org/3/library/subprocess.html#subprocess.call) to offer protection against attack.

Left unchecked, subprocess.run and subprocess.call can execute any arbitrary system command. If an attacker can control part of the strings used as program paths or arguments, they could execute arbitrary programs, install malware, and anything else they could do if they had a shell open on the application host.

Our change introduces a sandbox which protects the application:

  import subprocess
+ from security import safe_command
  ...
- subprocess.run("echo 'hi'", shell=True)
+ safe_command.run(subprocess.run, "echo 'hi'", shell=True)
  ...
- subprocess.call(["ls", "-l"])
+ safe_command.call(subprocess.call, ["ls", "-l"])

The default safe_command restrictions applied are the following:

• Prevent command chaining. Many exploits work by injecting command separators and causing the shell to interpret a second, malicious command. The safe_command functions attempt to parse the given command, and throw a SecurityException if multiple commands are present.
• Prevent arguments targeting sensitive files. There is little reason for custom code to target sensitive system files like /etc/passwd, so the sandbox prevents arguments that point to these files that may be targets for exfiltration.

There are more options for sandboxing if you are interested in locking down system commands even more.

Dependency Updates

This codemod relies on an external dependency. We have automatically added this dependency to your project's requirements.txt file.

This library holds security tools for protecting Python API calls.

There are a number of places where Python project dependencies can be expressed, including setup.py, pyproject.toml, setup.cfg, and requirements.txt files. If this change is incorrect, or if you are using another packaging system such as poetry, it may be necessary for you to manually add the dependency to the proper location in your project.

More reading

• https://github.com/pixee/python-security/blob/main/src/security/safe_command/api.py
• https://cheatsheetseries.owasp.org/cheatsheets/OS_Command_Injection_Defense_Cheat_Sheet.html

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: pixee:python/sandbox-process-creation

[pixeebot]

This library holds security tools for protecting Python API calls.

License: MIT ✅ Open Source ✅ More facts

[kaizen-bot]

🔍 Code Review Summary

✅ All Clear: This commit looks good! 👍

Overview

• Total Feedbacks: 0 (Critical: 0, Refinements: 0)
• Files Affected: 0
• Code Quality: [██████████████████░░] 90% (Excellent)

✨ Generated with love by Kaizen ❤️

Useful Commands

• Feedback: Share feedback on kaizens performance with !feedback [your message]
• Ask PR: Reply with !ask-pr [your question]
• Review: Reply with !review
• Update Tests: Reply with !unittest to create a PR with test changes