-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix invalid escape sequences (python 3.12 SyntaxWarning) #459
fix invalid escape sequences (python 3.12 SyntaxWarning) #459
Conversation
(I could add a changelog section, but not sure what version this would target. 1.30.0? 1.29.1? |
b2sdk/raw_simulator.py
Outdated
@@ -1159,7 +1159,7 @@ class RawSimulator(AbstractRawApi): | |||
DOWNLOAD_URL_MATCHER = re.compile( | |||
DOWNLOAD_URL + '(?:' + '|'.join( | |||
( | |||
'/b2api/v[0-9]+/b2_download_file_by_id\?fileId=(?P<file_id>[^/]+)', | |||
'/b2api/v[0-9]+/b2_download_file_by_id?fileId=(?P<file_id>[^/]+)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like this regexp was invalid from the beginning.
Instead "fix" should be just adding r
i.e. r'...'
as otherwise this ?
will mean d
is optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point.
As for the changelog, we use towncrier to manage main file, so you just create a new one and don't worry about versions yourself. P.S. thanks for contributing |
4da69dc
to
f82a1e8
Compare
@ehossack the changelog files need to follow a specific naming scheme. Edit: since this fixes issue #458, the name of the changelog file should be |
f82a1e8
to
ced69f3
Compare
Sorry, new process and also I didn't properly read the section you linked 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you!
I don't see any reason to not do this (nothing in sphinx?).
As referenced in #458