Update projects to .NET 8 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we brought in Microsoft.Extensions.Caching.StackExchangeRedis, it bumped the transitive version of Microsoft.IdentityModel to v7+ while before we used v6.x. There was a breaking change between these versions that switched Json.NET to System.Text.Json. However, our dependencies still used v6 of the OpenIdConnect which at runtime cannot find the new type. Easiest way to fix this is to bring in .NET 8 so the versions are all on the latest supported platforms. This brings in some required changes for downstream API access and application insights configuration. See https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/wiki/IdentityModel-7x#serialization-issues for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we brought in Microsoft.Extensions.Caching.StackExchangeRedis, it bumped the transitive version of Microsoft.IdentityModel to v7+ while before we used v6.x. There was a breaking change between these versions that switched Json.NET to System.Text.Json. However, our dependencies still used v6 of the OpenIdConnect which at runtime cannot find the new type. See https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/wiki/IdentityModel-7x#serialization-issues for details.
Easiest way to fix this is to bring in .NET 8 so the versions are all on the latest supported platforms. This brings in some required changes for downstream API access and application insights configuration.