Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with spaces in override values!? #82

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

cbikhazi
Copy link
Contributor

#81

Potential fix for this issue?

@cbikhazi cbikhazi requested a review from a team as a code owner April 18, 2023 16:32
@github-actions
Copy link

github-actions bot commented May 2, 2023

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label May 2, 2023
Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciej-ciach
Copy link

Can we get this fix merged and released as a new version, please?

@davidgamero @JeannedArk @aamgayle @Vidya2606 @jaiveerk @nonylene

@github-actions github-actions bot removed the idle Inactive for 14 days label Sep 25, 2023
@nonylene
Copy link
Contributor

you mention me but I'm just a external contributor, not a collaborator

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Oct 9, 2023
@jaiveerk
Copy link
Contributor

jaiveerk commented Oct 9, 2023

@cbikhazi would you mind signing your commits? This guide on GPG-signing may be useful to check out. Thanks again for the contribution!

@cbikhazi cbikhazi force-pushed the issue-81 branch 2 times, most recently from b98ffee to 5ac94fc Compare October 9, 2023 16:27
@cbikhazi
Copy link
Contributor Author

cbikhazi commented Oct 9, 2023

@jaiveerk - I have updated the commit to be signed. thanks

@github-actions github-actions bot removed the idle Inactive for 14 days label Oct 9, 2023
@jaiveerk jaiveerk merged commit dcbd995 into Azure:main Oct 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants