Add support for headers artifacts #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blanquicet
force-pushed
the
artifact-headers
branch
from
48c2aa3 to
0dcf578
Compare
|
Looking into the test failure. |
|
Seems like |
I'm not sure I got it. Mmmm why is it failing just for Jammy? |
|
Sorry, |
|
#387 should fix the issue you are seeing. |
dh-exec has some limitations that we can't really get around. The immediate need is it can't copy a directory to a new name in the target location. As such we need more flexibility in how we set things up, so this switches to bash so we can have the power that we need. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
blanquicet
force-pushed
the
artifact-headers
branch
from
0dcf578 to
156dfcb
Compare
Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
blanquicet
force-pushed
the
artifact-headers
branch
from
156dfcb to
ce3202b
Compare
cpuguy83
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds support for header artifacts.
Which issue(s) this PR fixes: We want to give dalec users the ability to add header artifacts to their packages.
Special notes for your reviewer: