Allow custom worker images #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
image_from_context
branch
3 times, most recently
from
c500e35 to
c21788d
Compare
cpuguy83
force-pushed
the
image_from_context
branch
from
c21788d to
293cb70
Compare
cpuguy83
force-pushed
the
image_from_context
branch
from
293cb70 to
1e30236
Compare
adamperlin
reviewed
Jul 25, 2024
adamperlin
reviewed
Jul 25, 2024
adamperlin
reviewed
Jul 25, 2024
adamperlin
reviewed
Jul 25, 2024
This allows builders to provide their own worker image. This enables builders to install their own repos, as an example, or use pre-built workers. Adds `azlinux3/worker`, `mariner2/worker`, and `windowscross/worker/` build targets which outputs each worker image respectively. You can take the output of these, inject whatever is needed, and feed that as an input into another build. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
image_from_context
branch
from
1e30236 to
75337da
Compare
adamperlin
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow custom worker images
This allows builders to provide their own worker image via build context.
This enables builders to install their own repos, as an example, or use pre-built workers.
Adds
azlinux3/worker,mariner2/worker, andwindowscross/worker/build targets which outputs each worker image respectively.You can take the output of these, inject whatever is needed, and feed that as an input into another build.
Note: By using the image ref as a build-context name, this brings dalec more inline with how Dockerfile works as well.