offsetScaledLogVariance: change it to unsigned short (SCA _032 #65) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static code analysis fix _032 (Issue Avnu#65) SCA complains here about ntohs() but the real issue is the type of offsetScaledLogVariance, which currently in the code is int16_t. There seems to be inconsistency in IEEE 802.1AS-2011: - in 6.3.3.8 ClockQuality offsetScaledLogVariance is defined as UInteger16; - later in the document it's used as Integer16 (Table 14-1, code examples etc.); This inconsistency has been corrected in IEEE 802.1AS-2011/Cor 1-2013 where UInteger16 was specified in the Table 14-1 and used later in the code examples.
|
Please review |
|
Hello, hello! Any comments here? |
|
Anybody out there? |
MarcinMiklas
requested changes
Feb 28, 2023
linux/shm_test/shm_test.cpp
Outdated
| @@ -113,7 +113,7 @@ int main(int argc, char *argv[]) | |||
| (unsigned int) ptpData->clock_identity[6], (unsigned int) ptpData->clock_identity[7]); | |||
| fprintf(stdout, "priority1 %u\n", (unsigned int) ptpData->priority1); | |||
| fprintf(stdout, "clock_class %u\n", (unsigned int) ptpData->clock_class); | |||
| fprintf(stdout, "offset_scaled_log_variance %d\n", (int) ptpData->offset_scaled_log_variance); | |||
| fprintf(stdout, "offset_scaled_log_variance %d\n", (unsigned int) ptpData->offset_scaled_log_variance); | |||
There was a problem hiding this comment.
%u should be used for printing unsigned int
MarcinMiklas
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static code analysis fix _032 (Issue #65)
SCA complains here about ntohs() but the real issue is the type of offsetScaledLogVariance,
which currently in the code is int16_t. There seems to be inconsistency in IEEE 802.1AS-2011:
This inconsistency has been corrected in IEEE 802.1AS-2011/Cor 1-2013 where UInteger16 was specified
in the Table 14-1 and used later in the code examples. IEEE 1588-2008 defines offsetScaledLogVariance also
as UInteger16 (see 5.3.7 ClockQuality).