-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WordAds]: Add sticky ad format settings #98444
base: trunk
Are you sure you want to change the base?
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~93 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is why you're not seeing the settings saved correctly. They are part of the display_options
object.
wordads_bottom_sticky_enabled: settings.bottom_sticky_enabled, | ||
wordads_sidebar_sticky_right_enabled: settings.sidebar_sticky_right_enabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wordads_bottom_sticky_enabled: settings.bottom_sticky_enabled, | |
wordads_sidebar_sticky_right_enabled: settings.sidebar_sticky_right_enabled, | |
wordads_bottom_sticky_enabled: settings.display_options.bottom_sticky_enabled, | |
wordads_sidebar_sticky_right_enabled: settings.display_options.sidebar_sticky_right_enabled, |
Related to #
Proposed Changes
(IT'S TO BE USED WHEN WE ACTIVATE THE MIGRATED FORMAT, WE CAN'T MERGE NOW AFAIK)
Why are these changes being made?
Testing Instructions
Tools > Monetize > Ads > Settings
Stick to the bottom of each page
andStick to the right side of each page
optionsStick to the bottom of each page
should enable the sticky ad format on the bottom of the page (i.e., bottom sticky) and vice versa.?wordads-logging=true
to see the logs (but without the query stringbottom_sticky=true
).Stick to the right side of each page
should enable sticky ad format on the right side of the page (i.e. sticky sidebar right) and vice versa.sidebar_sticky_right=true
)Pre-merge Checklist