Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains Management Revamp: Fix breadcrumb line break on smaller screens #98431

Open
wants to merge 3 commits into
base: add/domains-management-compare-email-providers
Choose a base branch
from
Open

Domains Management Revamp: Fix breadcrumb line break on smaller screens #98431

wants to merge 3 commits into from
+15 −2

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Jan 15, 2025

Related to #98275

Proposed Changes

  • Fix breadcrumb line break for domain names on smaller screens.
    • This is to avoid horizontal scrolling when displaying bigger domain names.

Why are these changes being made?

  • This is part of the Domain Management Revamp project: pfuQfP-13x-p2

Testing Instructions

  • Apply this PR to your local.
  • Go to http://calypso.localhost:3000/sites?flags=calypso/all-domain-management.
  • Click on a site with a domain previously configured and without email configured.
  • Scroll down to the domains table and click on the domain.
  • You should see the domain overview page within the site context.
  • Click on the Email tab.
  • Click on "See how they compare" link.
  • Switch to a small screen size (like mobile sizes).
  • You should see the words on breadcrumb items breaking correctly, except for the domain name, which should break anywhere.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp self-assigned this Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-129889
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-129889&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-129889&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Jan 15, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~50 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-main                   -49 B  (-0.0%)      -26 B  (-0.0%)
entry-login                  -49 B  (-0.0%)      -26 B  (-0.0%)
entry-domains-landing        -49 B  (-0.0%)      -25 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~19 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
hosting                                  +446 B  (+0.0%)      +41 B  (+0.0%)
domains                                  +261 B  (+0.0%)      +17 B  (+0.0%)
update-design-flow                        -49 B  (-0.0%)      -22 B  (-0.0%)
link-in-bio-tld-flow                      -49 B  (-0.0%)      -22 B  (-0.0%)
copy-site-flow                            -49 B  (-0.0%)      -22 B  (-0.0%)
email                                     +36 B  (+0.0%)       +8 B  (+0.0%)
woocommerce-installation                  +22 B  (+0.0%)       +6 B  (+0.0%)
themes                                    +22 B  (+0.0%)       +6 B  (+0.0%)
theme                                     +22 B  (+0.0%)       +6 B  (+0.0%)
subscribers                               +22 B  (+0.0%)       +6 B  (+0.0%)
stats                                     +22 B  (+0.0%)       +6 B  (+0.0%)
staging-site                              +22 B  (+0.0%)       +6 B  (+0.0%)
sites-dashboard                           +22 B  (+0.0%)       +6 B  (+0.0%)
site-tools                                +22 B  (+0.0%)       +6 B  (+0.0%)
site-settings                             +22 B  (+0.0%)       +6 B  (+0.0%)
site-purchases                            +22 B  (+0.0%)       +6 B  (+0.0%)
site-performance                          +22 B  (+0.0%)       +6 B  (+0.0%)
site-overview                             +22 B  (+0.0%)       +6 B  (+0.0%)
site-monitoring                           +22 B  (+0.0%)       +6 B  (+0.0%)
site-marketing                            +22 B  (+0.0%)       +6 B  (+0.0%)
site-logs                                 +22 B  (+0.0%)       +6 B  (+0.0%)
site-blocks                               +22 B  (+0.0%)       +6 B  (+0.0%)
settings-writing                          +22 B  (+0.0%)       +6 B  (+0.0%)
settings-security                         +22 B  (+0.0%)       +6 B  (+0.0%)
settings-reading                          +22 B  (+0.0%)       +6 B  (+0.0%)
settings-podcast                          +22 B  (+0.0%)       +6 B  (+0.0%)
settings-performance                      +22 B  (+0.0%)       +6 B  (+0.0%)
settings-newsletter                       +22 B  (+0.0%)       +6 B  (+0.0%)
settings-jetpack                          +22 B  (+0.0%)       +6 B  (+0.0%)
settings-discussion                       +22 B  (+0.0%)       +6 B  (+0.0%)
settings                                  +22 B  (+0.0%)       +6 B  (+0.0%)
security                                  +22 B  (+0.0%)       +6 B  (+0.0%)
scan                                      +22 B  (+0.0%)       +6 B  (+0.0%)
reader                                    +22 B  (+0.0%)       +6 B  (+0.0%)
purchases                                 +22 B  (+0.0%)       +6 B  (+0.0%)
privacy                                   +22 B  (+0.0%)       +6 B  (+0.0%)
posts-custom                              +22 B  (+0.0%)       +6 B  (+0.0%)
posts                                     +22 B  (+0.0%)       +6 B  (+0.0%)
plugins                                   +22 B  (+0.0%)       +6 B  (+0.0%)
plans                                     +22 B  (+0.0%)       +6 B  (+0.0%)
people                                    +22 B  (+0.0%)       +6 B  (+0.0%)
pages                                     +22 B  (+0.0%)       +6 B  (+0.0%)
notification-settings                     +22 B  (+0.0%)       +6 B  (+0.0%)
media                                     +22 B  (+0.0%)       +6 B  (+0.0%)
me                                        +22 B  (+0.0%)       +6 B  (+0.0%)
marketing                                 +22 B  (+0.0%)       +6 B  (+0.0%)
jetpack-cloud-settings                    +22 B  (+0.0%)       +6 B  (+0.0%)
jetpack-cloud-plugin-management           +22 B  (+0.0%)       +6 B  (+0.0%)
jetpack-cloud-partner-portal              +22 B  (+0.0%)       +6 B  (+0.0%)
jetpack-cloud-agency-sites-v2             +22 B  (+0.0%)       +6 B  (+0.0%)
import                                    +22 B  (+0.0%)       +6 B  (+0.0%)
hosting-features                          +22 B  (+0.0%)       +6 B  (+0.0%)
home                                      +22 B  (+0.0%)       +6 B  (+0.0%)
help                                      +22 B  (+0.0%)       +6 B  (+0.0%)
google-my-business                        +22 B  (+0.0%)       +6 B  (+0.0%)
github-deployments                        +22 B  (+0.0%)       +6 B  (+0.0%)
export                                    +22 B  (+0.0%)       +6 B  (+0.0%)
earn                                      +22 B  (+0.0%)       +6 B  (+0.0%)
developer                                 +22 B  (+0.0%)       +6 B  (+0.0%)
comments                                  +22 B  (+0.0%)       +6 B  (+0.0%)
backup                                    +22 B  (+0.0%)       +6 B  (+0.0%)
add-ons                                   +22 B  (+0.0%)       +6 B  (+0.0%)
activity                                  +22 B  (+0.0%)       +6 B  (+0.0%)
account-close                             +22 B  (+0.0%)       +6 B  (+0.0%)
account                                   +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-team                     +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-sites                    +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-settings                 +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-referrals                +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-purchases                +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-plugins                  +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-partner-directory        +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-overview                 +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-migrations               +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-marketplace              +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-landing                  +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-client                   +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies-agency-tier              +22 B  (+0.0%)       +6 B  (+0.0%)
a8c-for-agencies                          +22 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~66 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     -49 B  (-0.0%)      -25 B  (-0.0%)
async-load-signup-steps-domains                                                         -49 B  (-0.0%)      -22 B  (-0.0%)
async-load-purchase-modal-wrapper                                                       -49 B  (-0.0%)      -25 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -49 B  (-0.0%)      -25 B  (-0.0%)
async-load-calypso-my-sites-checkout-modal                                              -49 B  (-0.0%)      -25 B  (-0.0%)
async-load-store-app-store-stats                                                        +22 B  (+0.0%)       +6 B  (+0.0%)
async-load-design-playground                                                            +22 B  (+0.0%)       +6 B  (+0.0%)
async-load-design                                                                       +22 B  (+0.0%)       +6 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@phcp phcp force-pushed the fix/domains-management-breadcrumb-styles branch from 4b885d6 to dac0d87 Compare January 15, 2025 17:46
@phcp phcp force-pushed the add/domains-management-compare-email-providers branch from c4244be to b7845fd Compare January 15, 2025 17:46
@phcp phcp marked this pull request as ready for review January 15, 2025 17:51
@phcp phcp requested a review from a team January 15, 2025 17:51
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 15, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/domains-management-breadcrumb-styles on your sandbox.

@phcp phcp changed the title Domains Management Revamp: Fix breadcrumb line break for smaller screens Domains Management Revamp: Fix breadcrumb line break on smaller screens Jan 15, 2025
bogiii
bogiii approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming, it looks better now!

Screenshot 2025-01-15 at 19 44 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogiii bogiii bogiii approved these changes

Assignees

@phcp phcp

Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phcp @matticbot @bogiii