Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains Management Revamp: Add email plans comparison subpage to site context #98430

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Jan 15, 2025

Closes #98275

Proposed Changes

  • Add email plans comparison subpage to the site context.

Why are these changes being made?

  • This is part of the Domain Management Revamp project: pfuQfP-13x-p2

Testing Instructions

  • Apply this PR to your local
  • Go to http://calypso.localhost:3000/sites?flags=calypso/all-domain-management.
  • Click on a site with a domain previously configured and without email configured.
  • Scroll down to the domains table and click on the domain.
  • You should see the domain overview page within the site context.
  • Click on the Email tab.
  • Click on "See how they compare" link.
  • The plans comparison page should be rendered in the site context.
  • Select one of the email plans.
  • It should return to the Email overview page with the correct plan expanded, and it should continue in the site context.
  • Go back to the plans comparison page.
  • Switch to Monthly plans and select a different plan.
  • It should return to the Email overview page with the correct interval selected and the plan expanded, and it should continue in the site context.
  • Test the navigation using the breadcrumb, it should continue in the site context.
  • Perform regression tests in the domain context.
  • The page should behave the same, and the navigation should stay within the domain context.
  • Go to the old UI and perform regression tests (WP Admin -> Hosting -> Email).
  • The page should work as before, without changes in visual or behavior.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp requested a review from a team January 15, 2025 17:33
@phcp phcp self-assigned this Jan 15, 2025
@phcp phcp requested a review from a team as a code owner January 15, 2025 17:33
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 15, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 15, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~50 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-main                   -49 B  (-0.0%)      -26 B  (-0.0%)
entry-login                  -49 B  (-0.0%)      -26 B  (-0.0%)
entry-domains-landing        -49 B  (-0.0%)      -25 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~19 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
hosting                    +191 B  (+0.0%)       +3 B  (+0.0%)
update-design-flow          -49 B  (-0.0%)      -22 B  (-0.0%)
link-in-bio-tld-flow        -49 B  (-0.0%)      -22 B  (-0.0%)
copy-site-flow              -49 B  (-0.0%)      -22 B  (-0.0%)
email                       +14 B  (+0.0%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~72 bytes removed 📉 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     -49 B  (-0.0%)      -25 B  (-0.0%)
async-load-signup-steps-domains                                                         -49 B  (-0.0%)      -22 B  (-0.0%)
async-load-purchase-modal-wrapper                                                       -49 B  (-0.0%)      -25 B  (-0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        -49 B  (-0.0%)      -25 B  (-0.0%)
async-load-calypso-my-sites-checkout-modal                                              -49 B  (-0.0%)      -25 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@phcp phcp force-pushed the add/domains-management-compare-email-providers branch from c4244be to b7845fd Compare January 15, 2025 17:46
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the flow inside the site context and works as described.
Anyway, I found one issue in the domains context with the breadcrumbs email link. It redirect to the old UI.

We probably need to build a URL relative to the current route. You can see how I recently handled for some other cases.

https://github.com/Automattic/wp-calypso/blob/trunk/client/my-sites/domains/domain-management/subpage-wrapper/headers/add-mailbox-header.tsx#L29-L31

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The only issue I saw is in domain context, the Email breadcrumb takes the user fully out of the revamped context

Screenshot 2025-01-16 at 12 41 12 AM

@phcp phcp requested review from bogiii and Imran92 January 15, 2025 22:03
@phcp
Copy link
Contributor Author

phcp commented Jan 15, 2025

@Imran92 @bogiii, nice catch! I just pushed a fix for that, also fixed on the Email Forwarding page.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/domains-management-compare-email-providers on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site-context: Open the "Compare email plans" page in site-context layout
4 participants