Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate views: Implement A/A test (Calypso) #98428

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jan 15, 2025

Proposed Changes

Implements an A/A test to validate that the "Remove duplicate views" experiment works as expected in Calypso.

See p1736957876238999/1736840785.753609-slack-C04DZ8M0GHW

Why are these changes being made?

Because new ExPlat client implementations need to be A/A tested.

Testing Instructions

N/A

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Remove Duplicate Views labels Jan 15, 2025
@mmtr mmtr self-assigned this Jan 15, 2025
@mmtr mmtr requested review from jessie-ross, aaronyan, isatuncman-auto and a team January 15, 2025 17:16
@mmtr mmtr changed the title Remove duplicate views: Implement A/A test Remove duplicate views: Implement A/A test (Calypso) Jan 15, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/remove-duplicate-views-aa-test on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~15 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-main         +47 B  (+0.0%)      +15 B  (+0.0%)
entry-login        +47 B  (+0.0%)      +15 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jessie-ross jessie-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary variables but looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Remove Duplicate Views [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants