Staging sites: Add Delete staging site button to the Staging Site tab (when managing staging site)

[ivan-ottinger]

Resolves https://github.com/Automattic/dotcom-forge/issues/9974.

Proposed Changes

In this draft PR I am proposing a solution that adds Delete staging site button to the Staging site tab when we are managing that specific staging site:

ℹ️ Please ignore the styling for the moment. That's something I am planning to work on later.

The proposed solution works as follows:

1. Renders the Delete staging site button with confirmation modal.
2. When user confirms the action, the staging site deletion is triggered (through deleteStagingSite).
3. User is automatically navigated to the Staging Site tab on the Production site. This is required as the staging site is being deleted.
4. The staging site revert / deletion process continues and completes.

There's still one issue that I haven't been able to figure out yet: Even the staging site revert / deletion process finishes, the UI does not update for the user. Here's a screen recording to better illustrate:

Screen.Capture.on.2025-01-15.at.15-07-26.mp4

Instead, the Add staging site button should get rendered automatically as soon as the staging site is deleted:

When investigating this issue, it turns out that the /sites/${ siteId }/staging-site endpoint (queried in client/sites/tools/staging-site/hooks/use-staging-site.ts) does not get re-triggered and hence the app still thinks the staging site exists.

So far we tried to solve the issue by manually invalidating the USE_STAGING_SITE_QUERY_KEY query (as can be seen in the PR), but that doesn't seem to work reliably.

I would appreciate any feedback / thoughts on the proposed changes and what do you think about the query issue. I am happy to jump on a call if that helps.

Why are these changes being made?

• https://github.com/Automattic/dotcom-forge/issues/9974

Testing Instructions

1. Apply the PR branch and build the app.
2. On an existing Atomic site create a new staging site.
3. Navigate to the Staging Site tab of the staging site and try to delete the staging site.
4. Observe the behavior.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129860

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129860&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129860&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• command-palette-wp-admin
• help-center
• notifications
• odyssey-stats
• whats-new
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/delete-staging-site-button-to-staging-site-tab on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~342 bytes added 📈 [gzipped])

name          parsed_size           gzip_size
staging-site       +921 B  (+0.1%)     +180 B  (+0.0%)
site-tools         +921 B  (+0.1%)     +162 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.