Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Fix failing tests on Gutenberg build #98409

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

gavande1
Copy link
Contributor

@gavande1 gavande1 commented Jan 15, 2025

Related to p1736902807354689-slack-CBTN58FTJ

Proposed Changes

Testing Instructions

  • Set up your test env using this guide.
  • To run the test on the edge GB version, get the failing test paths listed here and run TEST_ON_ATOMIC=true GUTENBERG_EDGE=true yarn workspace wp-e2e-tests test -- [test path]. These may be easier ways to run the suite, which I don't know about.
  • The PR E2E tests should be passing.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@gavande1 gavande1 changed the title [WIP] E2E: Fix Editor Canvas test E2E: Fix failing tests on Gutenberg build Jan 15, 2025
@gavande1 gavande1 requested a review from fushar January 15, 2025 11:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 15, 2025
@gavande1 gavande1 requested a review from nightnei January 15, 2025 11:39
@gavande1
Copy link
Contributor Author

Another test is failing due to changes in the Jetpack Form. The field name was changed from Website to URL. However, the team has reverted the change/PR. I will check with them what is best way to address this.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe; as long as the actual GB E2E tests are passing then it should be good.

@gavande1 gavande1 merged commit 25c1964 into trunk Jan 16, 2025
20 checks passed
@gavande1 gavande1 deleted the fix/editor-canvas-e2e-gb-update branch January 16, 2025 05:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants