-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme_color_override_with_admin_color_scheme flag and use to update meta theme color tag #98381
base: trunk
Are you sure you want to change the base?
Add theme_color_override_with_admin_color_scheme flag and use to update meta theme color tag #98381
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~2 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@tyxla also pointed out another environment config variable called |
2ed13df
to
e0e5406
Compare
Related to #98335
Needs #98380 to be merged first
Proposed Changes
theme_color_override_with_admin_color_scheme
environment config option<meta name="theme-color" />
tag dynamically on the client whenever a user updates the admin color schemeWhy are these changes being made?
To match the desired behavior described in #98335. This feature is currently broken, as the
data-colorscheme
attribute that the logic relies is not applied in the code anymore (probably removed my mistake in a previous refactor).This PR reinstates the behavior, but it changes the logic: instead of relying on the
theme-color
being defined or not (which is fragile and unclear), it uses a dedicated environment config option. Not only this logic is more clear, but it is also compatible with the changes being proposed in #98380Testing Instructions
<meta name="theme-color" />
tag in the page/wp-admin/profile.php
)<meta name="theme-color" />
tag and make sure it follows the main color of the new chosen themetheme_color_override_with_admin_color_scheme
tofalse
for the relevant environment (eg development), and make sure that the<meta name="theme-color" />
tag doesn't follow the admin color scheme<meta name="theme-color" />
tag fixed, ie. they should not update it to follow any changes from the admin color scheme.Pre-merge Checklist