Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused yarn version #98352

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove unused yarn version #98352

merged 1 commit into from
Jan 14, 2025

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jan 14, 2025

Proposed Changes

Remove unused yarn version.

This was introduced in #91833. It seems to have been unintentional. It's not used, the 4.0.2 version is used:

yarnPath: .yarn/releases/yarn-4.0.2.cjs

Why are these changes being made?

The file should not exist in the repo.

Testing Instructions

The package manager works as expected. Try yarn and yarn start.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sirreal sirreal added the [Type] Tooling Related to tools, scripts, automation, DevX, etc. label Jan 14, 2025
@sirreal sirreal requested review from gius80 and a team January 14, 2025 15:45
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 14, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/unused-yarn-version on your sandbox.

@sirreal sirreal mentioned this pull request Jan 14, 2025
8 tasks
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@sirreal
Copy link
Member Author

sirreal commented Jan 14, 2025

See #98354 for an upgrade to latest stable yarn version.

@sirreal sirreal merged commit f64616f into trunk Jan 14, 2025
14 of 15 checks passed
@sirreal sirreal deleted the remove/unused-yarn-version branch January 14, 2025 16:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
@tyxla
Copy link
Member

tyxla commented Jan 15, 2025

Thanks for the cleanup @sirreal 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Tooling Related to tools, scripts, automation, DevX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants