Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Add utils for user profile #98346

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

mehmoodak
Copy link
Member

Related to https://github.com/Automattic/loop/issues/273

Proposed Changes

We are currently hardcoding the names of user profile feature flags and URLs in various places. To improve maintainability, added isUserProfileEnabled and getUserProfileUrl util functions.

This also helps prevent unwanted typos.

Why are these changes being made?

To improve maintainability and consistency.

Testing Instructions

  • Go to user profile page (example) and verify that the page is working as expected.
  • Go to /read and verify author profile links are working as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mehmoodak mehmoodak self-assigned this Jan 14, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 14, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~128 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
write-flow                            +241 B  (+0.0%)     +117 B  (+0.0%)
plugins                               +241 B  (+0.0%)     +117 B  (+0.0%)
link-in-bio-tld-flow                  +241 B  (+0.0%)     +117 B  (+0.0%)
jetpack-cloud-plugin-management       +241 B  (+0.0%)     +117 B  (+0.0%)
home                                  +241 B  (+0.0%)     +117 B  (+0.0%)
build-flow                            +241 B  (+0.0%)     +117 B  (+0.0%)
reader                                +222 B  (+0.0%)     +128 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~117 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                  +241 B  (+0.0%)     +117 B  (+0.0%)
async-load-calypso-components-web-preview-component       +241 B  (+0.1%)     +117 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mehmoodak mehmoodak force-pushed the reader/add-user-profile-utils branch from e473188 to c0ab1c7 Compare January 14, 2025 14:37
@mehmoodak mehmoodak marked this pull request as ready for review January 14, 2025 15:48
@mehmoodak mehmoodak requested a review from a team as a code owner January 14, 2025 15:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
@mehmoodak mehmoodak requested review from a team as code owners January 14, 2025 16:00
@mehmoodak mehmoodak requested a review from aneeshd16 January 14, 2025 16:00
@matticbot
Copy link
Contributor

matticbot commented Jan 14, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug reader/add-user-profile-utils on your sandbox.

Base automatically changed from loop-273/update-avatar-links to trunk January 16, 2025 08:17
@mehmoodak mehmoodak removed request for a team and aneeshd16 January 16, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants