-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Add utils for user profile #98346
base: trunk
Are you sure you want to change the base?
Conversation
This reverts commit ac9f207.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~128 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~117 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
e473188
to
c0ab1c7
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Related to https://github.com/Automattic/loop/issues/273
Proposed Changes
We are currently hardcoding the names of user profile feature flags and URLs in various places. To improve maintainability, added
isUserProfileEnabled
andgetUserProfileUrl
util functions.This also helps prevent unwanted typos.
Why are these changes being made?
To improve maintainability and consistency.
Testing Instructions
/read
and verify author profile links are working as expected.Pre-merge Checklist