Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Alternative means of variation cloning #98319

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 14, 2025

Proposed Changes

Introduces an alternative cloning mechanism in case structuredClone doesn't exist. Adding since this seems to be occurring for hundreds of users per day.

Why are these changes being made?

Resolves https://a8c.sentry.io/issues/6191478529/?project=6313676&referrer=project-issue-stream

Testing Instructions

See #97808

@tyxla tyxla added [Type] Enhancement [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. labels Jan 14, 2025
@tyxla tyxla self-assigned this Jan 14, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/gutenberg-bridge-clone-variation on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~25 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
patterns        +57 B  (+0.0%)      +25 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~23 bytes added 📈 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-automattic-global-styles-src-components-global-styles-variations        +57 B  (+0.0%)      +23 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@tyxla tyxla merged commit 2177d8f into trunk Jan 14, 2025
13 checks passed
@tyxla tyxla deleted the fix/gutenberg-bridge-clone-variation branch January 14, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants