Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PluginIcon image to not be square #98299

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

paulopmt1
Copy link
Contributor

Related to #98297

Proposed Changes

  • Not forcing plugin image to use a fixed size will allow us to support not square images

Why are these changes being made?

Testing Instructions

  • Go to [/me/security/connected-applications](http://calypso.localhost:3000/me/security/connected-applications) and ensure it renders icons without distorting them
  • Go to to /plugins/manage and ensure we still render everything as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@paulopmt1 paulopmt1 requested a review from a team January 14, 2025 00:54
@paulopmt1 paulopmt1 self-assigned this Jan 14, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
@paulopmt1 paulopmt1 linked an issue Jan 14, 2025 that may be closed by this pull request
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/plugin-icons-size on your sandbox.

Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulopmt1 paulopmt1 merged commit e3c0cdb into trunk Jan 14, 2025
14 checks passed
@paulopmt1 paulopmt1 deleted the fix/plugin-icons-size branch January 14, 2025 11:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connected application icons are distorted
3 participants