Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix /me/get-apps link for Studio on mobile #98281

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

bcotrim
Copy link
Contributor

@bcotrim bcotrim commented Jan 13, 2025

Related to https://github.com/Automattic/dotcom-forge/issues/6983
Follow-up to #98159

Proposed Changes

  • Fix link and text shown on mobile for the Studio apps

Why are these changes being made?

  • The wrong link is being shown at the moment

Testing Instructions

  1. On mobile devices:

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bcotrim bcotrim requested a review from a team January 13, 2025 16:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/get_apps_studio_mobile_link on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~36 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
site-blocks                 +174 B  (+0.0%)      +36 B  (+0.0%)
security                    +174 B  (+0.0%)      +36 B  (+0.0%)
purchases                   +174 B  (+0.0%)      +36 B  (+0.0%)
privacy                     +174 B  (+0.0%)      +36 B  (+0.0%)
notification-settings       +174 B  (+0.0%)      +36 B  (+0.0%)
me                          +174 B  (+0.0%)      +36 B  (+0.0%)
help                        +174 B  (+0.0%)      +36 B  (+0.0%)
developer                   +174 B  (+0.0%)      +36 B  (+0.0%)
account-close               +174 B  (+0.0%)      +36 B  (+0.0%)
account                     +174 B  (+0.0%)      +36 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bcotrim bcotrim merged commit 82bd8a4 into trunk Jan 14, 2025
15 checks passed
@bcotrim bcotrim deleted the fix/get_apps_studio_mobile_link branch January 14, 2025 07:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 14, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants