Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Actions API in a4a sites #98276

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

oandregal
Copy link
Contributor

@oandregal oandregal commented Jan 13, 2025

Work in Progress

Proposed Changes

This PR removes the Actions field in the A4A/sites screen in favor of using the Actions API.

Actions:

  • Prepare for launch
  • Set up site
  • Change domain
  • Hosting configuration
  • Issue new license @oandregal
  • View activity
  • Copy this site
  • Site settings
  • View site
  • Visit WP Admin
  • Remove site @oandregal
  • Delete site @oandregal

Why are these changes being made?

Otherwise, the list view doesn't work properly when updating DataViews to the latest version in #96470

Testing Instructions

TBD

@oandregal oandregal force-pushed the add/actions-to-a4a-sites branch from 69958b0 to 90ca71b Compare January 13, 2025 13:42
@oandregal oandregal self-assigned this Jan 13, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 13, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~399 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
a8c-for-agencies-sites      +1591 B  (+0.1%)     +399 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@oandregal oandregal force-pushed the add/actions-to-a4a-sites branch from 90ca71b to c54fb5b Compare January 15, 2025 17:41
@oandregal oandregal requested a review from jkguidaven January 15, 2025 18:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 15, 2025
@oandregal oandregal requested a review from a team January 15, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants