Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains Management Revamp: Show the Edit Contact Information subpage in site context #98274

Merged
merged 9 commits into from
Jan 13, 2025

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Jan 13, 2025

Closes #97966

Proposed Changes

  • Update SiteIcon component to support breadcrumb styles.
  • Apply the SiteIcon component to the breadcrumb for domain subpages within the site context.
  • Create a route for the Edit Contact Information subpage in the site context and update paths.
  • Update styles to match the page in the domain context.
  • Additional style fixes to match design on Figma.

Why are these changes being made?

  • This is part of the Domain Management Revamp project: pfuQfP-13x-p2.

Testing Instructions

  • Apply this PR to your local.
  • Go to http://calypso.localhost:3000/sites?flags=calypso/all-domain-management.
  • Click on a site with a domain previously configured.
  • Scroll down to the domains table and click on the domain.
  • You should see the domain overview page within the site context.
  • Expand the Contact information card and click Edit.
  • You should see the Edit Contact Information subpage within the site context.
  • Edit some information and click Save contact info.
  • You should be redirected to the domain overview page within the site context.
  • Go back to the Edit Contact Information and click cancel.
  • You should also be redirected to the domain overview page within the site context.
  • Go back to the Edit Contact Information and navigate using the breadcrumb.
  • It should behave correctly, keeping the navigation within the site context.
  • Perform regression tests on the Edit Contact Information in the domain context.
  • Perform regression tests on the Edit Contact Information in the previous layout.
  • Make sure the SiteIcon changes didn't affect anywhere else where it's used, mostly icons in the sites list.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp self-assigned this Jan 13, 2025
@phcp phcp requested a review from a team January 13, 2025 13:30
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 13, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/domains-management-contact-info on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 13, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~349 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                 +2153 B  (+0.1%)     +290 B  (+0.1%)
entry-login                 +533 B  (+0.0%)     +181 B  (+0.0%)
entry-domains-landing       +533 B  (+0.1%)     +175 B  (+0.1%)
entry-subscriptions         +357 B  (+0.0%)     +116 B  (+0.0%)
entry-stepper               +357 B  (+0.0%)     +116 B  (+0.0%)
entry-browsehappy           +357 B  (+0.2%)     +116 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~8219 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
domains                   +2509 B  (+0.1%)    +1726 B  (+0.3%)
hosting                   +1918 B  (+0.1%)    +1835 B  (+0.2%)
staging-site               +900 B  (+0.1%)    +1631 B  (+0.4%)
sites-dashboard            +900 B  (+0.1%)    +1631 B  (+0.5%)
site-tools                 +900 B  (+0.1%)    +1631 B  (+0.3%)
site-settings              +900 B  (+0.1%)    +1631 B  (+0.4%)
site-performance           +900 B  (+0.1%)    +1631 B  (+0.4%)
site-overview              +900 B  (+0.1%)    +1631 B  (+0.4%)
site-monitoring            +900 B  (+0.1%)    +1631 B  (+0.4%)
site-marketing             +900 B  (+0.1%)    +1631 B  (+0.4%)
site-logs                  +900 B  (+0.1%)    +1631 B  (+0.4%)
hosting-features           +900 B  (+0.1%)    +1631 B  (+0.4%)
github-deployments         +900 B  (+0.1%)    +1631 B  (+0.4%)
update-design-flow         +176 B  (+0.0%)      +50 B  (+0.0%)
link-in-bio-tld-flow       +176 B  (+0.0%)      +50 B  (+0.0%)
copy-site-flow             +176 B  (+0.0%)      +50 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~183 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                    +176 B  (+0.0%)      +62 B  (+0.0%)
async-load-signup-steps-domains                                                        +176 B  (+0.0%)      +56 B  (+0.0%)
async-load-purchase-modal-wrapper                                                      +176 B  (+0.0%)      +62 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       +176 B  (+0.0%)      +62 B  (+0.1%)
async-load-calypso-my-sites-checkout-modal                                             +176 B  (+0.0%)      +65 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But in smaller screens, the breadcrumb is causing the page to be scrollable on x-axis and also going out of bounds

Screen.Recording.2025-01-13.at.8.59.14.PM.mov

@phcp
Copy link
Contributor Author

phcp commented Jan 13, 2025

But in smaller screens, the breadcrumb is causing the page to be scrollable on x-axis and also going out of bounds

Just pushed a fix. Thanks for catching that, @Imran92!

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a small comment

@phcp phcp merged commit e393e31 into trunk Jan 13, 2025
11 checks passed
@phcp phcp deleted the add/domains-management-contact-info branch January 13, 2025 17:00
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site-context: Show the Edit Contact Information sub-page
3 participants