Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update threshold for feedback prompts #98263

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Jan 13, 2025

Related to:

  • Initial project thread: pejTkB-1Lb-p2
  • Updated discussions: pbNhbs-bVb-p2#comment-24747

Note: Do not merge until we have approval in the linked P2. Until then, this PR will remain a DRAFT.

Proposed Changes

Drop the high-traffic threshold from 10k to 1k visits. All sites with more than 1k visits in the past 30 days will now see the feedback prompts.

Why are these changes being made?

Part of our effort to solicit feedback and positive reviews.

Testing Instructions

  • Spin up the Calypso Live link.
  • Visit the Traffic page for any self-hosted site. You can test via Calypso by manually updating the URL path to this format: /stats/day/SITE_SLUG — Otherwise Calypso will redirect you to /wp-admin.
  • If the site has more than 1k views in the past 30 days, you should see the inline feedback card at the bottom of the page.
  • If you have not previously dismissed the popup prompt, it should display after a short delay.
  • Sites with 1k+ views will always show the inline prompt at the bottom of the page.
  • Sites with less than that threshold will only show the inline prompt at the bottom of the page if they have a commercial plan. ie: Sites with a plan can always access the feedback UI, regardless of traffic.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ck3n a8ck3n self-assigned this Jan 13, 2025
@a8ck3n a8ck3n added DO NOT MERGE [Feature] Stats Everything related to our analytics product at /stats/ labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE [Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants