Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A > Referrals: Update Referral link lifespan disclaimer to 7 days #98261

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Jan 13, 2025

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1658

Proposed Changes

This PR updates the disclaimer for the referral cart lifespan from 12 hours to 7 days.

Why are these changes being made?

We got some direct feedback from a partner agency: this referral would be so much more useful if it can stay for 2 weeks. or at least 1 week..

Testing Instructions

  • Open the A4A live link
  • Go to Marketplace > Toggle the refer mode > Add a few products > Go to Checkout and verify that the referral lifespan disclaimer is updated to 7 days as shown below
  • It is being updated it: 169917-ghe-Automattic/wpcom
Screenshot 2025-01-13 at 2 54 47 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team January 13, 2025 09:33
@yashwin yashwin self-assigned this Jan 13, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 13, 2025
@yashwin yashwin changed the title A4A > Referrals: Update Referral magic link lifespan disclaimer to 7 days A4A > Referrals: Update Referral link lifespan disclaimer to 7 days Jan 13, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@travisw
Copy link
Contributor

travisw commented Jan 13, 2025

Looks good 🚀

@yashwin yashwin merged commit 261771d into trunk Jan 14, 2025
16 of 20 checks passed
@yashwin yashwin deleted the update/referral-magic-link-lifespan branch January 14, 2025 02:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants