Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Minor style updates to chart tooltips #98254

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Jan 13, 2025

Related to: https://github.com/Automattic/red-team/issues/295

Proposed Changes

  • Removes the text decoration from the post titles as they aren't clickable
  • Removes the gradient from post titles
  • Updates width constraints to account for longer titles

Before

SCR-20250113-nfeu

After

SCR-20250113-pfor

Why are these changes being made?

Fixes visual glitch and improves readability.

Testing Instructions

  1. Spin up the Calypso Live site.
  2. Visit the Traffic page for a site with recent posts.
  3. Scrub the chart until you see a tooltip with post titles.
  4. Confirm the underline & gradient are gone.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@a8ck3n a8ck3n self-assigned this Jan 13, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 13, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/minor-tooltip-style-fixes on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ck3n a8ck3n marked this pull request as ready for review January 13, 2025 08:40
@a8ck3n a8ck3n requested a review from a team January 13, 2025 08:41
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
@a8ck3n a8ck3n added the [Feature] Stats Everything related to our analytics product at /stats/ label Jan 13, 2025
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! LGTM 👍

@a8ck3n a8ck3n force-pushed the fix/minor-tooltip-style-fixes branch from 6491c36 to 7ebebb7 Compare January 14, 2025 05:32
@a8ck3n a8ck3n merged commit 2be08be into trunk Jan 14, 2025
10 checks passed
@a8ck3n a8ck3n deleted the fix/minor-tooltip-style-fixes branch January 14, 2025 05:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants