Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downtime monitoring to site settings #98250

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Jan 13, 2025

Fixes #98188

Todo:

  • Revert the revert
  • Remove from Site (general) Settings section
  • Consider hiding the new placement in server settings (SMP) from those not in the treatment group We decided it's not worth it. p1736747647206859/1736742960.758409-slack-CRWCHQGUB

Proposed Changes

  • Moves Jetpack Downtime Monitoring options that refer to dotcom user account email / notifications to Site Settings

Testing Instructions

  • View site settings with an atomic site, see the full Jetpack Downtime Monitoring option toggles present
  • View site settings with a Jetpack self hosted site, see the full Jetpack Downtime Monitoring option toggles present

Screenshot 2025-01-13 at 16-31-02 Site Settings ‹ Site Title — WordPress com

@lsl lsl requested a review from a team January 13, 2025 05:31
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
@lsl lsl changed the title Update/downtime monitoring move Add downtime monitoring to site settings Jan 13, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/downtime-monitoring-move on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 13, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2391 bytes added 📈 [gzipped])

name               parsed_size           gzip_size
staging-site           +9769 B  (+0.6%)    +2253 B  (+0.5%)
hosting                +9532 B  (+0.3%)    +2224 B  (+0.3%)
settings-security       +969 B  (+0.2%)     +157 B  (+0.1%)
site-tools               -13 B  (-0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl self-assigned this Jan 13, 2025
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the settings on a Simple site. I think it's not expected? 🤔

image

@lsl
Copy link
Contributor Author

lsl commented Jan 14, 2025

I can see the settings on a Simple site. I think it's not expected? 🤔

It is not, must not have any checks for site type internally. It lives on security settings which is only available to atomic so that make sense.

We're moving this to server settings now anyway. Will revert the revert.

Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be good to put it on the Monitoring tab, but I realized that it would be better to have all the settings in Server Settings, so LGTM!
Screenshot 2025-01-14 at 10 56 53

@lsl lsl merged commit bef0800 into trunk Jan 14, 2025
12 of 15 checks passed
@lsl lsl deleted the update/downtime-monitoring-move branch January 14, 2025 04:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Add downtime monitoring to Site Settings
4 participants