-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable skipped Woo signup test and update woocommerce.com URL #98246
Conversation
…on test - Updated the URL pattern in the UserSignupPage to correctly match 'woocommerce.com'. - Changed the 'Activate account' test from skipped to active, allowing it to run as part of the onboarding flow.
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I believe it uses the historical data to determine if it's flaky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, lgtm! 🚀
Related to p1736297762145419-slack-C01SFMVEYAK
We disabled the Woo signup test in #98057 because it was failing and blocking the release.
The error occurs because the page navigation is being interrupted during the account activation step.
Two navigation were happening at the same time because we didn't wait for the previous navigation to complete.
We have two points in the Slack thread but I believe it's not related to the error:
https://woocommerce.com/?error=access-denied
because when the user signs up and is redirected back to WCCOM, WCCOM will check a URL parameterstate
to see if it is through WooCommerce.com to Wordpress.com signup flow. If not, it will redirect tohttps://woocommerce.com/?error=access-denied
. Our e2e test entry point is directly to the Wordpress.com signup URL instead of to WooCommerce.com because I think the e2e test shouldn't depend on external services like WCCOM.Confirm your email
. However, the e2e test is using the href to match the link instead of the text.To fix the test, I added a
waitUntil: 'networkidle'
option towaitForURL
andpage.goto()
calls. This should make the test more reliable. Additionally, I updated the URL in the e2e test from woo.com to woocommerce.com since we've already moved back to woocommerce.com.Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-Release E2E Tests should pass
To test locally:
yarn workspace wp-e2e-tests test test/e2e/specs/onboarding/signup__woo-email.ts
yarn workspace wp-e2e-tests test -- test/e2e/specs/authentication/authentication__totp.ts
Pre-merge Checklist