-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk Plugins Management: Adds list view #98240
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~92 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the changes, I think this greatly improves the small viewports views. I have reviewed the changes and they LGTM. I have a couple of non-blocking comments
- When clicking on an item of the list, then closing and then resizing again. I have observed a weird behaviour. This is so specific that I consider this non-blockinng. Please see a video
CleanShot.2025-01-15.at.11.54.58.mp4
- Would it be possible to open the plugins when selecting anywhere in the cell? It was a bit confusing to me to see the
pointer
cursor but not been able to click. I see that this already happens in the table view so it is not related to this specific PR, but commenting here in case is something that can be addressed as part of this or another PR.
Fixes https://github.com/Automattic/dotcom-forge/issues/9854
Proposed Changes
list
type for the plugins list dataview when opening the sites list pane or when viewport is smaller than960px
.Why are these changes being made?
Testing Instructions
/plugins/manage/sites
Pre-merge Checklist