Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Plugins Management: Adds list view #98240

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented Jan 12, 2025

Fixes https://github.com/Automattic/dotcom-forge/issues/9854

Proposed Changes

  • Used list type for the plugins list dataview when opening the sites list pane or when viewport is smaller than 960px.

Why are these changes being made?

  • The changes aim to make the navigation friendlier, especially in mobile viewports

Testing Instructions

  • Go to /plugins/manage/sites
  • See how the plugin list changes to list view and back to table view when you navigate to a specific plugin or when the viewport gets < 960px
Before After
CleanShot 2025-01-13 at 21 11 11 CleanShot 2025-01-13 at 21 11 25
CleanShot 2025-01-13 at 21 26 20 CleanShot 2025-01-13 at 21 26 31

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 12, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plugins-dashboard-add-mobile-view on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 12, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~92 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                               +342 B  (+0.0%)      +92 B  (+0.0%)
jetpack-cloud-plugin-management       +342 B  (+0.0%)      +92 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cpapazoglou cpapazoglou self-assigned this Jan 13, 2025
@cpapazoglou cpapazoglou changed the title Adds mobile view Bulk Plugins Management: Adds list view Jan 13, 2025
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes, I think this greatly improves the small viewports views. I have reviewed the changes and they LGTM. I have a couple of non-blocking comments

  1. When clicking on an item of the list, then closing and then resizing again. I have observed a weird behaviour. This is so specific that I consider this non-blockinng. Please see a video
CleanShot.2025-01-15.at.11.54.58.mp4
  1. Would it be possible to open the plugins when selecting anywhere in the cell? It was a bit confusing to me to see the pointer cursor but not been able to click. I see that this already happens in the table view so it is not related to this specific PR, but commenting here in case is something that can be addressed as part of this or another PR.
    CleanShot 2025-01-15 at 12 09 34@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants