Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using page calypso router to navigate to /home to avoid flickering #98229

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Jan 10, 2025

Related to #98166

Proposed Changes

  • Fixing flickering effect while navigating from Settings to Home after saving site's name

Why are these changes being made?

  • We want a better user experience on any detail

Testing Instructions

  • Follow this video steps on a free site
  • Make sure the /home navigation occurs without that blank page transition:
Screen.Recording.2025-01-10.at.16.07.51.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~15 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
site-settings               +32 B  (+0.0%)       +5 B  (+0.0%)
site-marketing              +32 B  (+0.0%)       +5 B  (+0.0%)
settings-writing            +32 B  (+0.0%)       +5 B  (+0.0%)
settings-security           +32 B  (+0.0%)       +5 B  (+0.0%)
settings-reading            +32 B  (+0.0%)       -4 B  (-0.0%)
settings-podcast            +32 B  (+0.0%)      -16 B  (-0.0%)
settings-performance        +32 B  (+0.0%)       +5 B  (+0.0%)
settings-newsletter         +32 B  (+0.0%)       +5 B  (+0.0%)
settings-discussion         +32 B  (+0.0%)       +5 B  (+0.0%)
settings                    +32 B  (+0.0%)       +5 B  (+0.0%)
people                      +32 B  (+0.0%)       +5 B  (+0.0%)
marketing                   +32 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 requested a review from a team January 10, 2025 19:09
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@paulopmt1 paulopmt1 self-assigned this Jan 10, 2025
@paulopmt1 paulopmt1 linked an issue Jan 10, 2025 that may be closed by this pull request
Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! LGTM

@paulopmt1 paulopmt1 merged commit df0fa43 into trunk Jan 10, 2025
15 checks passed
@paulopmt1 paulopmt1 deleted the update/page-redirect-after-saving-settings branch January 10, 2025 20:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove stepper screen when completing launchpad task
4 participants