Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builk Plugin Management: Use the same URL for Manage Plugins to avoid recreating the Dashboard #98228

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

epeicher
Copy link
Contributor

@epeicher epeicher commented Jan 10, 2025

Resolves https://github.com/Automattic/dotcom-forge/issues/10214

Proposed Changes

  • Use the same /plugins/manage/sites URL to navigate when clicking on Manage sites

Note: An alternative solution was tried as part of a546395, but this solution fixes the root cause of the issue and it does not add additional code.

Before

CleanShot.2025-01-10.at.18.17.52.mp4

After

CleanShot.2025-01-10.at.18.18.31.mp4

Why are these changes being made?

  • It improves the performance by reusing existing data

Testing Instructions

  • Apply this patch and navigate to /plugins/manage/sites
  • Select a plugin from the list
  • Click on the Manage Plugins icon in the left-hand sidebar
  • Select another plugin
  • Check the list of plugins is kept and there is no loading indicator
  • Check that selecting other plugins work as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 10, 2025

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@epeicher epeicher changed the title Builk Plugin Management: Use existing plugin list when available Builk Plugin Management: Use the same URL for Manage Plugins to avoid recreating the Dashboard Jan 10, 2025
@epeicher epeicher requested a review from paulopmt1 January 10, 2025 17:42
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/get-current-plugins-selector on your sandbox.

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🕵️

@epeicher epeicher merged commit 30f45cb into trunk Jan 10, 2025
15 checks passed
@epeicher epeicher deleted the add/get-current-plugins-selector branch January 10, 2025 17:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for improving it @epeicher, that's great! It's so much better now!

Not related to this PR, but since I was testing it, I noticed that when sliding the content to the left, it's not 100% smooth, and it takes about 1s to start it giving the impression that the interface is "a bit slow".

We can see that on seconds 2, 6 and 11 of the video. Do you think we can improve that effect transition to start right away and be more smooth?

Screen.Recording.2025-01-10.at.15.07.06.mov

@epeicher
Copy link
Contributor Author

Not related to this PR, but since I was testing it, I noticed that when sliding the content to the left, it's not 100% smooth, and it takes about 1s to start it giving the impression that the interface is "a bit slow".

Do you think we can improve that effect transition to start right away and be more smooth?

Absolutely @paulopmt1, I agree the animation feels a bit janky, I am going to iterate with the approach done in a546395 and see if it improves. I will create a different task for that.

@epeicher
Copy link
Contributor Author

The following linked task has been created to investigate performance improvements to make the animation smoother https://github.com/Automattic/dotcom-forge/issues/10230

@paulopmt1
Copy link
Contributor

Thanks so much for continuing to follow up with it, @epeicher!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants