-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builk Plugin Management: Use the same URL for Manage Plugins to avoid recreating the Dashboard #98228
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🕵️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for improving it @epeicher, that's great! It's so much better now!
Not related to this PR, but since I was testing it, I noticed that when sliding the content to the left, it's not 100% smooth, and it takes about 1s to start it giving the impression that the interface is "a bit slow".
We can see that on seconds 2, 6 and 11 of the video. Do you think we can improve that effect transition to start right away and be more smooth?
Screen.Recording.2025-01-10.at.15.07.06.mov
Absolutely @paulopmt1, I agree the animation feels a bit janky, I am going to iterate with the approach done in a546395 and see if it improves. I will create a different task for that. |
The following linked task has been created to investigate performance improvements to make the animation smoother https://github.com/Automattic/dotcom-forge/issues/10230 |
Thanks so much for continuing to follow up with it, @epeicher! |
Resolves https://github.com/Automattic/dotcom-forge/issues/10214
Proposed Changes
/plugins/manage/sites
URL to navigate when clicking onManage sites
Note: An alternative solution was tried as part of a546395, but this solution fixes the root cause of the issue and it does not add additional code.
Before
CleanShot.2025-01-10.at.18.17.52.mp4
After
CleanShot.2025-01-10.at.18.18.31.mp4
Why are these changes being made?
Testing Instructions
/plugins/manage/sites
Manage Plugins
icon in the left-hand sidebarPre-merge Checklist