Sites Dashboard: Implement survey

[taipeicoder]

Proposed Changes

This PR implements a survey popup as proposed in pfYzsZ-1ib-p2. The survey will only be shown to 15% of English locale users, but it can be forced via the URL parameter show_survey.

Note

This PR updates the SurveyModal component, see below on its impact.

GitHub Deployment Survey

Before	After

SSO Survey

Before	After

Why are these changes being made?

pfYzsZ-1ib-p2

Testing Instructions

• Head to /sites?show_survey
• Ensure that the survey is displayed as intended
• Ensure that clicking the CTA opens a new tab with the intended URL
• Ensure that clicking close or "No thanks" closes the survey and is not displayed again on page refresh
• Ensure that clicking the backdrop closes the survey and it's displayed again on page refresh
• (Optional) Change locale and ensure that the survey is not displayed. There will be a flash of the survey since non production environments tend to take longer for the locale to be applied.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129550

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129550&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129550&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~27 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main        +48 B  (+0.0%)      +27 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~349 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site            +3296 B  (+0.2%)     +903 B  (+0.2%)
sites-dashboard         +3296 B  (+0.3%)     +903 B  (+0.3%)
site-settings           +3296 B  (+0.2%)     +903 B  (+0.2%)
site-performance        +3296 B  (+0.2%)     +903 B  (+0.2%)
site-overview           +3296 B  (+0.2%)     +903 B  (+0.2%)
site-monitoring         +3296 B  (+0.2%)     +903 B  (+0.2%)
site-marketing          +3296 B  (+0.2%)     +903 B  (+0.2%)
site-logs               +3296 B  (+0.2%)     +903 B  (+0.2%)
hosting-features        +3296 B  (+0.3%)     +903 B  (+0.2%)
hosting                 +3296 B  (+0.1%)     +903 B  (+0.1%)
site-tools               +795 B  (+0.0%)     +334 B  (+0.1%)
github-deployments       +795 B  (+0.1%)     +334 B  (+0.1%)
settings-security         -63 B  (-0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/sites-survey on your sandbox.

[arthur791004]

Tested and works as expected!

[taipeicoder]

@matt-west one change is that the title for the GitHub Deployments survey now drops to a second line. Let me know if this is something you'd like to address.

[matt-west]

one change is that the title for the GitHub Deployments survey now drops to a second line. Let me know if this is something you'd like to address.

@taipeicoder I think this is okay.

The screenshot in the modal looks really blurry. Can you export that at a higher-resolution. Let me know if you need any help.

[taipeicoder]

@matt-west could you try disabling this CSS rule and see if it does the trick? I can merge the code tomorrow if that fixes it.

[matt-west]

@taipeicoder Sadly that didn’t help. It still appears blurry. I’m testing in Safari.

Screen.Recording.2025-01-13.at.15.19.18.mov