-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Library: Add resize handle tooltip #98215
Pattern Library: Add resize handle tooltip #98215
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~66 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fredrikekelund. This looks good.
At first I thought it was a bit weird that the Resize
tooltip goes away when you click on the handle, but I think that actually makes sense otherwise we’d need to drag the tooltip too which is a bit awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks good.
I am not sure if it helps too much, though, as when the user hovers over the resize handle, the cursor already changes to the resize version, so the tooltip seems to be redundant.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17193312 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @fredrikekelund, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Related to https://github.com/Automattic/dotcom-forge/issues/6582
Follow-up to #98087
Proposed Changes
I overlooked adding a tooltip to the Pattern Library preview resize handle in #98087. This PR fixes that.
Why are these changes being made?
To help clarify the purpose of the resize handle, which isn't universally understood at first glance.
Testing Instructions
/patterns/about
Pre-merge Checklist