Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Library: Add resize handle tooltip #98215

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

fredrikekelund
Copy link
Contributor

Related to https://github.com/Automattic/dotcom-forge/issues/6582
Follow-up to #98087

Proposed Changes

I overlooked adding a tooltip to the Pattern Library preview resize handle in #98087. This PR fixes that.

Why are these changes being made?

To help clarify the purpose of the resize handle, which isn't universally understood at first glance.

Testing Instructions

  1. Navigate to /patterns/about
  2. Ensure that the resize handle next to the pattern previews displays a tooltip when you hover it and that it works as expected

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@fredrikekelund fredrikekelund requested review from matt-west and a team January 10, 2025 13:22
@fredrikekelund fredrikekelund self-assigned this Jan 10, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 10, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug f26d/pattern-preview-resize-handle-tooltip on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~66 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
patterns       +319 B  (+0.0%)      +66 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@matt-west matt-west left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredrikekelund. This looks good.

At first I thought it was a bit weird that the Resize tooltip goes away when you click on the handle, but I think that actually makes sense otherwise we’d need to drag the tooltip too which is a bit awkward.

Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good.

I am not sure if it helps too much, though, as when the user hovers over the resize handle, the cursor already changes to the resize version, so the tooltip seems to be redundant.

@fredrikekelund fredrikekelund merged commit bfce6ad into trunk Jan 13, 2025
15 checks passed
@fredrikekelund fredrikekelund deleted the f26d/pattern-preview-resize-handle-tooltip branch January 13, 2025 09:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 13, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17193312

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @fredrikekelund, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Resize

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants