Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: explain better what happens when plan renewal gets removed. #98206

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented Jan 10, 2025

Related to p1736438516533719/1736437664.065279-slack-C0117V2PCAE

Proposed Changes

When there is a plan renewal in cart together with some marketplace products ( eg plugin / theme ) we wrongly worded that removing the plan renewal will remove the marketplace products. Since the plan hasn't expired yet, the marketplace products are still eligible to be bought and used. This PR aims to make the message more precise.

Testing Instructions

  • In a site with a business or higher plan, add a plan renewal to the cart
  • Add a marketplace product in the cart
  • Go to the cart and click "Remove" in the plan renewal, you should see the updated message, click continue, plan gets removed, marketplace product remains

Regression testing

  • In a free site
  • Add a marketplace product in the cart
  • A business plan is added automatically
  • Go to the cart and click "Remove" in the plan, you should see Since some of your other product(s) depend on your plan to be purchased, they will also be removed from the cart. When you press Continue, these product(s) along with your new plan will be removed from the cart, and your site will continue to run on its current plan., continue, plan and product gets removed from cart

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@cpapazoglou cpapazoglou requested a review from a team as a code owner January 10, 2025 09:48
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 10, 2025
@cpapazoglou cpapazoglou self-assigned this Jan 10, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/checkout-plan-remove-renewal-for-marketplace on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~53 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
plans                                    +12 B  (+0.0%)      +53 B  (+0.0%)
jetpack-connect                          +12 B  (+0.0%)      +53 B  (+0.0%)
jetpack-cloud-pricing                    +12 B  (+0.0%)      +53 B  (+0.0%)
jetpack-cloud-plugin-management          +12 B  (+0.0%)      +53 B  (+0.0%)
jetpack-cloud-partner-portal             +12 B  (+0.0%)      +53 B  (+0.0%)
jetpack-cloud-manage-pricing             +12 B  (+0.0%)      +53 B  (+0.0%)
jetpack-cloud-features-comparison        +12 B  (+0.0%)      +53 B  (+0.0%)
jetpack-cloud-agency-sites-v2            +12 B  (+0.0%)      +53 B  (+0.0%)
checkout                                 +12 B  (+0.0%)      +53 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~53 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                     +12 B  (+0.0%)      +53 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +12 B  (+0.0%)      +53 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +12 B  (+0.0%)      +53 B  (+0.0%)
async-load-masterbar-cart-masterbar-cart-wrapper                                        +12 B  (+0.0%)      +53 B  (+0.1%)
async-load-calypso-my-sites-checkout-modal                                              +12 B  (+0.0%)      +53 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         +12 B  (+0.0%)      +53 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cpapazoglou cpapazoglou merged commit 7f8f6b5 into trunk Jan 10, 2025
15 checks passed
@cpapazoglou cpapazoglou deleted the fix/checkout-plan-remove-renewal-for-marketplace branch January 10, 2025 11:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 10, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17156900

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @cpapazoglou, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Some of your other product(s) depend on your plan to be renewed. When you press Continue, the plan renewal will be removed from the cart and your plan will keep its current expiry date. When the plan expires these product(s) will stop working even if they haven't expired yet.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Jan 14, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants